DataViews table layout: hide actions menu when there is only one action and is primary by oandregal · Pull Request #67020 · WordPress/gutenberg

oandregal · 2024-11-15T07:01:48Z

What?

This PR hides the actions menu for the DataViews table layout when there's only 1 action and is primary.

Before	After

All current core screens have more than one action. See testing instructions below.

Why?

To improve UX.

Testing Instructions

This is something we've heard from extenders. Because there's no place in core where we have this situation just yet, we have to create one for testing:

Go to the post-list code and remove the postTypeActions in this line and in the line below (in both arrays).
Visit the Pages page and switch to the table layout.
Verify the actions menu is hidden, only the edit icon is displayed.

github-actions · 2024-11-15T07:02:01Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: oandregal <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: ntsekouras <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Mamaduka

Works as advertised ✅

ntsekouras · 2024-11-15T08:02:36Z

packages/dataviews/src/components/dataviews-item-actions/index.tsx

+	primaryActions: Action< Item >[],
+	actions: Action< Item >[]
+) {
+	return primaryActions.length === 1 && actions.length;


Why not inline the check?

That could work as well. No big feelings either way. I suppose I thought it better to have it explain the why.

ntsekouras · 2024-11-15T08:13:00Z

Noting that we do this for every layout and not only for table. We should update the title.

I was a bit confused that list layout doesn't use these action components. It seems probably about adding some extra things for keyboard navigation and I'm wondering if we can absorb that somehow.

oandregal · 2024-11-15T08:30:08Z

Noting that we do this for every layout and not only for table. We should update the title.

This is actually only for the table. Here's the PR for the list #67015 :)

The list view uses the subcomponents directly to handle the keyboard interactions. The grid is unaffected because it uses the compact view (no primary actions visible). This can be tested by switching to any other layout during testing.

List	Grid	Table

ntsekouras · 2024-11-15T08:34:36Z

The list view uses the subcomponents directly to handle the keyboard interactions. The grid is unaffected because it uses the compact view (no primary actions visible). This can be tested by switching to any other layout during testing.

Exactly. If grid wasn't using the compact and had one primary action would have the same behavior. For now it doesn't, but when we open the API for registering layouts, this behavior will be for any layout.

oandregal · 2024-11-15T09:21:34Z

@ntsekouras Agreed. If things worked differently then yes, it'd make sense to change the changelog/issue title to be about all the layouts. I just worry that it'd be confusing to say so when it's not true right now? Not sure how it could be improved without being confusing, but happy to explore alternatives if you have any suggestion.

ntsekouras · 2024-11-15T09:53:46Z

The title is not that important right now, yes. We should keep this in mind when creating the API for layouts to document it.

okmttdhr · 2024-11-21T08:02:48Z

packages/dataviews/src/components/dataviews-item-actions/index.tsx

+	primaryActions: Action< Item >[],
+	actions: Action< Item >[]
+) {
+	return primaryActions.length === 1 && actions.length;


@oandregal I believe the condition actions.length should be updated to actions.length === 1. The current implementation only displays the primary action when there is exactly one primary action, even if additional non-primary actions are present.

https://wordpress.github.io/gutenberg/?path=/story/dataviews-dataviews--default

gutenberg/packages/dataviews/src/components/dataviews/stories/fixtures.tsx

Lines 610 to 615 in b7d989e

{

id: 'secondary',

label: 'Secondary action',

callback() {},

},

];

Thanks, @okmttdhr! Prepared a fix at #67197 The fix will be part of 19.8, as this PR is, which hasn't been released yet.

Hide the actions menu if only 1 action and is primary

dbed929

oandregal self-assigned this Nov 15, 2024

oandregal added [Type] Enhancement A suggestion for improvement. [Package] DataViews /packages/dataviews labels Nov 15, 2024

oandregal requested review from allilevine, cbravobernal, jameskoster, mcsf, ntsekouras, okmttdhr and youknowriad November 15, 2024 07:02

oandregal mentioned this pull request Nov 15, 2024

DataViews: when there's only one action and is primary, hide actions dropdown #65165

Closed

oandregal requested a review from ellatrix November 15, 2024 07:03

Mamaduka approved these changes Nov 15, 2024

View reviewed changes

ntsekouras reviewed Nov 15, 2024

View reviewed changes

oandregal merged commit 40954ff into trunk Nov 15, 2024

oandregal deleted the hide/actions-menu-table branch November 15, 2024 08:32

github-actions bot added this to the Gutenberg 19.8 milestone Nov 15, 2024

okmttdhr reviewed Nov 21, 2024

View reviewed changes

oandregal mentioned this pull request Nov 21, 2024

DataViews: fix action visibility logic #67197

Merged

bph added the [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond label Nov 25, 2024

ntsekouras mentioned this pull request Dec 20, 2024

DataViews: Don't render actions dropdown when all eligible ones are primary #68168

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DataViews table layout: hide actions menu when there is only one action and is primary#67020

DataViews table layout: hide actions menu when there is only one action and is primary#67020
oandregal merged 1 commit intotrunkfrom
hide/actions-menu-table

oandregal commented Nov 15, 2024

Uh oh!

github-actions bot commented Nov 15, 2024 •

edited

Loading

Uh oh!

Mamaduka left a comment

Uh oh!

ntsekouras Nov 15, 2024 •

edited

Loading

Uh oh!

oandregal Nov 15, 2024

Uh oh!

ntsekouras commented Nov 15, 2024

Uh oh!

oandregal commented Nov 15, 2024

Uh oh!

ntsekouras commented Nov 15, 2024

Uh oh!

oandregal commented Nov 15, 2024

Uh oh!

ntsekouras commented Nov 15, 2024

Uh oh!

okmttdhr Nov 21, 2024 •

edited

Loading

Uh oh!

oandregal Nov 21, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	{
	id: 'secondary',
	label: 'Secondary action',
	callback() {},
	},
	];

Conversation

oandregal commented Nov 15, 2024

What?

Why?

Testing Instructions

Uh oh!

github-actions bot commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mamaduka left a comment

Choose a reason for hiding this comment

Uh oh!

ntsekouras Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oandregal Nov 15, 2024

Choose a reason for hiding this comment

Uh oh!

ntsekouras commented Nov 15, 2024

Uh oh!

oandregal commented Nov 15, 2024

Uh oh!

ntsekouras commented Nov 15, 2024

Uh oh!

oandregal commented Nov 15, 2024

Uh oh!

ntsekouras commented Nov 15, 2024

Uh oh!

okmttdhr Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oandregal Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions bot commented Nov 15, 2024 •

edited

Loading

ntsekouras Nov 15, 2024 •

edited

Loading

okmttdhr Nov 21, 2024 •

edited

Loading

oandregal Nov 21, 2024 •

edited

Loading